Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nedbank implementation #6293

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Added nedbank implementation #6293

wants to merge 13 commits into from
+3,192 −168

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Dec 16, 2024 •
edited
Loading

AB#30631

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Copilot Copilot bot review requested due to automatic review settings December 16, 2024 13:22
Copilot
Copilot AI reviewed Dec 16, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@RubenGeo RubenGeo added the enhancement New feature or request that affects our end users label Jan 9, 2025
@RubenGeo RubenGeo changed the title Added nedbank to fsp enum to add an initial commit Added nedbank implementation Jan 10, 2025
diderikvw
diderikvw requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@diderikvw diderikvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost mid-way through, already delivering to Ruben for processing.

services/.env.example Outdated Show resolved Hide resolved
services/.env.example Outdated Show resolved Hide resolved
services/121-service/.gitignore Outdated Show resolved Hide resolved
services/121-service/src/cronjob/cronjob.service.ts Show resolved Hide resolved
services/121-service/src/cronjob/cronjob.service.ts Outdated Show resolved Hide resolved
...es/121-service/src/payments/fsp-integration/nedbank/dto/nedbank-create-order-response.dto.ts Outdated Show resolved Hide resolved
...es/121-service/src/payments/fsp-integration/nedbank/dto/nedbank-create-order-response.dto.ts Outdated Show resolved Hide resolved
...es/121-service/src/payments/fsp-integration/nedbank/dto/nedbank-create-order-response.dto.ts Outdated Show resolved Hide resolved
...es/121-service/src/payments/fsp-integration/nedbank/dto/nedbank-create-order-response.dto.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/dto/nedbank-get-order-reponse.dto.ts Outdated Show resolved Hide resolved
diderikvw
diderikvw requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@diderikvw diderikvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delivering review of Nedbank Module, except for unit tests. Small refactor stuff I think, except for the idempotency key, which may need a conversation to decide on what is optimal.

services/121-service/src/payments/fsp-integration/nedbank/nedbank.module.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank.service.ts Outdated Show resolved Hide resolved
...1-service/src/payments/fsp-integration/nedbank/dtos/create-order-request-body-nedbank.dto.ts Outdated Show resolved Hide resolved
...s/121-service/src/payments/fsp-integration/nedbank/interfaces/nedbank-create-order-params.ts Outdated Show resolved Hide resolved
...s/121-service/src/payments/fsp-integration/nedbank/interfaces/nedbank-create-order-params.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank-voucher.entity.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank-voucher.entity.ts Show resolved Hide resolved
services/121-service/src/queues-registry/queues-registry.module.ts Outdated Show resolved Hide resolved
services/121-service/src/queues-registry/queues-registry.module.ts Outdated Show resolved Hide resolved
services/121-service/src/queues-registry/queues-registry.module.ts Show resolved Hide resolved
diderikvw
diderikvw reviewed Jan 16, 2025
View reviewed changes
services/.env.example Outdated Show resolved Hide resolved
services/.env.example Outdated Show resolved Hide resolved
...s/121-service/src/reconciliation/nedbank-reconciliation/nedbank-reconciliation.controller.ts Outdated Show resolved Hide resolved
...ices/121-service/src/reconciliation/nedbank-reconciliation/nedbank-reconciliation.service.ts Outdated Show resolved Hide resolved
...s/121-service/src/reconciliation/nedbank-reconciliation/nedbank-reconciliation.controller.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank-api.service.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank-api.service.ts Outdated Show resolved Hide resolved
services/121-service/src/payments/fsp-integration/nedbank/nedbank-api.service.ts Outdated Show resolved Hide resolved
services/121-service/src/queues-registry/queues-registry.module.ts Outdated Show resolved Hide resolved
services/121-service/src/queues-registry/queues-registry.module.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@diderikvw diderikvw diderikvw requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request that affects our end users
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RubenGeo @diderikvw